Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Implement http interactions #160

Closed
wants to merge 6 commits into from
Closed

feature: Implement http interactions #160

wants to merge 6 commits into from

Conversation

l7ssha
Copy link
Member

@l7ssha l7ssha commented Oct 27, 2024 •
edited
Loading

Description

_commands part of support of http interactions

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality

Checklist:

  • Ran dart analyze .
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@l7ssha l7ssha added this to the 6.1.0 milestone Oct 27, 2024
@l7ssha l7ssha mentioned this pull request Oct 27, 2024
Closed
2 tasks
l7ssha
l7ssha commented Oct 27, 2024
View reviewed changes
lib/src/plugin/HttpInteractions.dart Outdated

import 'package:nyxx/src/utils/iterable_extension.dart';

abstract class HttpInteractionsPlugin implements NyxxPlugin<NyxxRest> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added Plugin to minimize possibility of confusion between our abstract and actual implementation

@l7ssha l7ssha removed this from the 6.1.0 milestone Oct 28, 2024
@l7ssha l7ssha added the invalid This doesn't seem right label Oct 28, 2024
@l7ssha l7ssha closed this Nov 3, 2024
@l7ssha l7ssha deleted the feature/http-interactions-support branch November 3, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lexedia Lexedia Lexedia left review comments

Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l7ssha @Lexedia