Skip to content

Conversation

@PDA-1
Copy link

@PDA-1 PDA-1 commented May 8, 2025

Channel 5 was missing from the list, it caused a wrong title name to be calculated.

I tried submitting a fix on the GuessIt project, but it seems no one is maintaining it recently.
guessit-io/guessit#799

To test the fix, the file name "Motorway.Cops.Catching.Britains.Speeders.S07E05.1080p.MY5.WEB-DL.AAC2.0.H.264-RAWR/Motorway.Cops.Catching.Britains.Speeders.S07E05.1080p.MY5.WEB-DL.AAC2.0.H.264-RAWR.mkv" can be used.
It returns a wrong title name before the addition, and a correct one after it.

@PDA-1 PDA-1 changed the title Fix: Added Chanell 5 to streaming services in options.json Fix: Added channel 5 to streaming services in options.json May 8, 2025
@dnzbk dnzbk self-requested a review May 8, 2025 05:55
@dnzbk
Copy link
Collaborator

dnzbk commented May 8, 2025

Thanks for the fix.
To ensure the fix doesn’t regress in the future, could you please add the problematic filename you provided to the testdata.json?

Also, because you’ve patched a vendored library, we need to properly acknowledge your changes. Please update the following section in the README.md file:

- [GuessIt 3.8.0](http://guessit.readthedocs.org) to extract information from file names and includes portions of code from [SABnzbd](https://sabnzbd.org/).
    - [patch 1](<link to your commit>) by [PDA-1](https://github.com/PDA-1) - <short description>

@PDA-1
Copy link
Author

PDA-1 commented May 8, 2025

Done.
It's the first time I'm doing all that, so if not done correctly, I apologize.

@dnzbk
Copy link
Collaborator

dnzbk commented May 8, 2025

Done. It's the first time I'm doing all that, so if not done correctly, I apologize.

You are doing well, no worries.

@dnzbk dnzbk merged commit b4760d8 into nzbgetcom:master May 8, 2025
1 check passed
@PDA-1 PDA-1 deleted the patch-1 branch September 24, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants