Skip to content

Comments

Fixed @defined and probe syntax#1

Open
Tanimodori wants to merge 2 commits intonzh63:masterfrom
Tanimodori:master
Open

Fixed @defined and probe syntax#1
Tanimodori wants to merge 2 commits intonzh63:masterfrom
Tanimodori:master

Conversation

@Tanimodori
Copy link

No description provided.

"array": {},
"function_dec": {
"begin": "(function)\\s+([\\w.]+)",
"begin": "(function)\\s([\\w.]+)",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More than one space is legal, for example: function foo(bar)

"include": "#comment"
},
{
"match": "(process|function|module|statement|begin|end|syscall|return|call|never)(?![@a-zA-Z0-9_$])",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some probes not in this list, see https://sourceware.org/systemtap/tapsets/

},
{
"include": "#number"
"include": "#expr"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should not accept variables

},
{
"match": "([*!?])",
"name": "keyword.operator.systemtap"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use keyword.operator.quantifier.systemtap instead

"patterns": [
{
"begin": "(?:(?<=:)\\s*([^\\s\\:]+))?(\\()",
"beginCaptures": {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is processe the type of rreturn value (like function foo:long(bar))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants