Merged
Conversation
This PR simply uses the same casing for the FROM and AS statements, as recommended by [Docker](https://docs.docker.com/go/dockerfile/rule/from-as-casing/)
SanabriaRusso
approved these changes
May 14, 2025
SanabriaRusso
requested changes
May 16, 2025
Collaborator
SanabriaRusso
left a comment
SanabriaRusso
left a comment
There was a problem hiding this comment.
We need to add shorter tags as to allow staging deployments to be isolated.
We have a hard 63-char limit to Kubernetes Namespace names, as well as for Ingress URLs 🤷 .
#123 deals with this by adding a truncated version of $github.sha as tag.
Adding an additional, shorter tag to the artifact will allow easier deployment-time configurations e.g., Ingress URLs. This will greatly simplify visualization for also debugging
SanabriaRusso
approved these changes
Jun 25, 2025
SanabriaRusso
approved these changes
Jun 25, 2025
Collaborator
|
!n8n-deploy-archive-node-api |
Collaborator
|
!n8n-destroy-archive-node-api |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
build.yamlworkflow triggered by PRs to the main branch that will bundle the branch into a docker build and upload the artifact to GCP.