Add left shift and right shift to finite field lib #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t bitwise operations on big integers
…ons in leftShift and rightShift
…ift implementation
MartinMinkov
commented
Oct 24, 2023
…anual shift implementation" This reverts commit fd87c4e.
The leftShift function in finite_field.ts is updated to limit the bit size to a maximum value. This change is necessary to prevent potential overflow issues when shifting large BigInt values. The default maxBitSize is set to 64, but can be configured as needed.
MartinMinkov
commented
Nov 2, 2023
Trivo25
approved these changes
Nov 2, 2023
…ft methods to correct bit shifting operations
mitschabaude
reviewed
Nov 2, 2023
Co-authored-by: Gregor Mitscha-Baude <gregor.mitscha-baude@gmx.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds left and right shift functions for finite fields in the case of constants.
Tested
This work is tested in the upper layers of o1js with unit and e2e tests that are built on top of the exposed gate constraint.
🔗 o1js: o1-labs/o1js#1194