Implement NOT gadget #194
Merged
Implement NOT gadget #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trivo25
reviewed
Oct 31, 2023
…eter to correctly calculate the bitwise negation of a bigint value
mitschabaude
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a not function for finite fields in the case of constants.
A bitwise
NOTis an operation that returns1in each bit position if the corresponding bit of the operand is0, and returns0if the corresponding bit of the operand is1.Tested
This work is tested in the upper layers of o1js with unit and e2e tests that are built on top of the exposed gate constraint.
🔗 o1js: o1-labs/o1js#1198