-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Add support to build bindings using mina as a submodule in o1js repo #222
Merged
Merged
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0fed0c1
feat: copy config files from mina submodule and change paths
MartinMinkov 775b4e1
fix(test_vectors): update paths to crypto/proof-systems in dump-test-…
MartinMinkov 553b281
fix(build-snarkyjs-web.sh, update-snarkyjs-bindings.sh): change SNARK…
MartinMinkov 0f16715
fix(dump-test-vectors.sh): change 'b10' to 'hex' in cargo run command…
MartinMinkov a0f12f9
feat(kimchi): remove kimchi, since it's been moved to mina repo
MartinMinkov e057e6f
feat: support compiling kimchi from mina repo
MartinMinkov dd3e1ea
fix(CODEOWNERS): remove kimchi directory from CODEOWNERS file as it n…
MartinMinkov ba45bf4
docs(README.md): remove '/kimchi' directory description as it is no l…
MartinMinkov a68de0e
feat: fix scripts for o1js building
MartinMinkov 285d40f
fix(lint.yaml): remove kimchi lib
MartinMinkov cf8d10f
feat(build-snarkyjs-node-artifacts.sh): add dune build command for co…
MartinMinkov f5fa4ca
feat: fixup bindings to compile with mina submodule in o1js
MartinMinkov ea3dfed
move /kimchi/{wasm,js} to kimchi_bindings
mitschabaude 887ed48
fix build scripts
mitschabaude 863867b
add script to help with dune build
mitschabaude 605608d
fixup
mitschabaude 039e1a3
update bindings
mitschabaude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,4 +15,3 @@ jobs: | |
run: | | ||
npm init -y | ||
npm i prettier | ||
npx prettier -c kimchi/js/**/*.js js/**/*.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,2 @@ | ||
/CODEOWNERS @bkase @mitschabaude @mrmr1993 | ||
/kimchi @o1-labs/crypto-eng-reviewers | ||
. @o1-labs/eng |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
The mina commit used to generate the backends for node and web is | ||
170a5b2cd4f936a4f5ab2085ff740370927e6f0d | ||
702042e3892edbc6a15ee8bac54cb7c36486eb53 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More changes have to be made in this file I think, for instance the build instructions.