perf recording

A bunch of patches to record some of the node perf data at runtime.

disable some reports, mkdir before writing

create the dirs so we can write there

adding error correction

fixing the collecting of output to after the unit tests finish

lets try to capture the results

fixing the job

update dirs

now listing the files and running different profs

adding more test

adding error checking to the copy

looking for isolate

removing extra move

fixing the directories

adding in a matrix of profile tests

adding node version to matrix

rename the artifact to include the node version

moving count to 32

perf

splitting the keccak test file into parts

by the sizes because so larger
fixme: refactor to reduce duplicate code and use parameters

reduce matrix size

perf recording

A bunch of patches to record some of the node perf data at runtime.

disable some reports, mkdir before writing

create the dirs so we can write there

adding error correction

fixing the collecting of output to after the unit tests finish

lets try to capture the results

fixing the job

update dirs

now listing the files and running different profs

adding more test

adding error checking to the copy

looking for isolate

removing extra move

fixing the directories

adding in a matrix of profile tests

adding node version to matrix

rename the artifact to include the node version

moving count to 32

perf

splitting the keccak test file into parts

by the sizes because so larger
fixme: refactor to reduce duplicate code and use parameters

reduce matrix size

all branchs

Refactoring output directory

We want the output directories to contain the branch name so we can
merge results easily. also using shellcheck
https://github.com/mschuett/yaml-shellcheck.git on the yaml.

fixing variable names

get rid of final slash that produces // double slashes

run only chunk 13 with more detail

.github/workflows/auto-merge-main-to-v2.yml

@@ -13,9 +13,10 @@
 name: Auto-merge main to v2
 
 on:
-  push:
-    branches:
-      - main
+  workflow_dispatch:
+#  push:
+#    branches:
+#      - main
 
 jobs:
   auto-merge:

.github/workflows/benchmarks.yml

@@ -1,9 +1,9 @@
 name: Benchmark o1js
 on:
-  push:
-    branches:
-      - main
-      - develop
+#  push:
+#    branches:
+#      - main
+#      - develop
   pull_request:
   workflow_dispatch: {}
 

.github/workflows/build-action.yml

@@ -1,9 +1,12 @@
 name: Build o1js
 on:
   push:
-    branches:
-      - main
-      - develop
+    #branches:
+    #  - feature/perf
+    #  - perf-recording
+    #  - main
+    #  - develop
+    #  - *
   pull_request:
   workflow_dispatch: {}
 
@@ -12,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     outputs:
       test_count: ${{ steps.count_tests.outputs.test_count }}
-      chunk_count: 8 # This is hardcoded to 8, but it can be changed to any number.
+      chunk_count: 32 # This is hardcoded to 8, but it can be changed to any number.
     steps:
       - name: Checkout repository with submodules
         uses: actions/checkout@v4
@@ -44,7 +47,7 @@ jobs:
         id: count_tests
         run: |
           TEST_COUNT=$(find ./dist/node -name "*.unit-test.js" | wc -l)
-          echo "test_count=${TEST_COUNT}" >> $GITHUB_OUTPUT
+          echo "test_count=${TEST_COUNT}" >> "$GITHUB_OUTPUT"
           echo "Total test count: ${TEST_COUNT}"
 
       - name: Cache repository
@@ -103,8 +106,8 @@ jobs:
       - name: Add to job summary
         if: always()
         run: |
-          echo "### Test Results for ${{ matrix.test_type }}" >> $GITHUB_STEP_SUMMARY
-          cat profiling.md >> $GITHUB_STEP_SUMMARY
+          echo "### Test Results for ${{ matrix.test_type }}" >> "$GITHUB_STEP_SUMMARY"
+          cat profiling.md >> "$GITHUB_STEP_SUMMARY"
 
   Run-Unit-Tests:
     needs: Prepare
@@ -114,7 +117,18 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        chunk: [1, 2, 3, 4, 5, 6, 7, 8]
+        chunk: [
+        #1,2,3,4,5,6,7,8,9,10,11,12,
+        13
+        #,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32
+        ]
+        perf: [
+        no,
+        prof, heap, cpu,
+        all]
+        node_version: [
+        18,20,22
+        ]
     steps:
       - name: Restore repository
         uses: actions/cache@v4
@@ -125,7 +139,8 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v4
         with:
-          node-version: '18'
+          # FIXME change to use matrix 
+          node-version: ${{ matrix.node_version }}
 
       - name: Restore cache
         uses: actions/cache@v4
@@ -138,17 +153,36 @@ jobs:
 
       - name: Prepare for tests
         run: touch profiling.md
+      - name: create dir
+        run: mkdir -p profile/profile-data
+        #- name: create dirs
+
+        # from https://stackoverflow.com/questions/75985925/how-to-replace-slashes-with-dashes-and-set-it-an-environment-variable-in-github
+      - name: Sets MODIFIED_BRANCH_NAME
+        env:
+          BRANCH_NAME: ${{ github.head_ref || github.ref_name }}           
+        run: |
+          MODIFIED_BRANCH_NAME=${BRANCH_NAME/\//-}
+          OUTPUT_DIR="profile/profile-data/${MODIFIED_BRANCH_NAME}"
+          OUTPUT_TEST_DIR="${OUTPUT_DIR}/profile-data-${{matrix.chunk}}-${{ matrix.perf }}-${{ matrix.node_version }}"
+
+          echo "MODIFIED_BRANCH_NAME=${MODIFIED_BRANCH_NAME}" >> "$GITHUB_ENV"
+          echo "OUTPUT_DIR=${OUTPUT_DIR}"                     >> "$GITHUB_ENV"
+          echo "OUTPUT_TEST_DIR=${OUTPUT_TEST_DIR}"           >> "$GITHUB_ENV"
+          
+      - name: create dir
+        run: mkdir -p ${{env.OUTPUT_TEST_DIR}}
 
       - name: Run unit tests
         env:
           TOTAL_TESTS: ${{ needs.Prepare.outputs.test_count }}
           CHUNK: ${{ matrix.chunk }}
-          CHUNKS: 8
+          CHUNKS: 32
         run: |
           echo "Total tests: $TOTAL_TESTS"
           echo "Current chunk: $CHUNK"
-          echo "Total chunks: $CHUNKS"
-
+          echo "Total chunks: $CHUNKS"          
+              
           if [ -z "$TOTAL_TESTS" ] || [ "$TOTAL_TESTS" -eq 0 ]; then
             echo "Error: TOTAL_TESTS is not set or is zero. Exiting."
             exit 1
@@ -162,26 +196,63 @@ jobs:
           shopt -s globstar
           test_files=(./dist/node/**/*.unit-test.js)
 
-          set -o pipefail
+          #set -o pipefail
 
           for ((i=start_index; i<end_index && i<${#test_files[@]}; i++)); do
               echo "Running test: ${test_files[$i]}"
-              node --enable-source-maps "${test_files[$i]}" | tee -a profiling.md
+
+              # NO prof
+              if [ "${{ matrix.perf }}" == "no" ]; then
+              echo no prof
+            (node --enable-source-maps "${test_files[$i]}" | tee -a profiling.md) || echo skip errors
+              fi
+
+              # cpu prof
+              if [ "${{ matrix.perf }}" == "cpu" ]; then
+              echo cpu
+              (node --cpu-prof --expose-gc --enable-source-maps "${test_files[$i]}" | tee -a profiling.md) || echo skip errors
+              fi
+
+              # HEAP
+              if [ "${{ matrix.perf }}" == "heap" ]; then
+              echo heap prof
+              (node --heap-prof --expose-gc --enable-source-maps "${test_files[$i]}" | tee -a profiling.md) || echo skip errors
+              fi
+
+              # PROF
+              if [ "${{ matrix.perf }}" == "prof" ]; then
+              echo prof
+              (node --prof --expose-gc --enable-source-maps "${test_files[$i]}" | tee -a profiling.md) || echo skip errors
+              fi
+
+              # ALL
+              if [ "${{ matrix.perf }}" == "all" ]; then
+              echo all prof
+              (node --prof --heap-prof --cpu-prof --expose-gc --enable-source-maps "${test_files[$i]}" | tee -a profiling.md) || echo skip errors
+
+              fi
+
+              # sweep up results
+              mv isolate-*-v8.log  "${OUTPUT_TEST_DIR}" || echo ok
+              mv Heap.*.heapprofile  "${OUTPUT_TEST_DIR}" || echo ok
+              mv CPU.*.cpuprofile "${OUTPUT_TEST_DIR}" || echo ok
+
+              
           done
-        continue-on-error: false
+        continue-on-error: true
 
       - name: Upload test results
         if: always()
         uses: actions/upload-artifact@v4
         with:
-          name: test-results-${{ matrix.chunk }}
-          path: profiling.md
+          name: test-results-${{env.MODIFIED_BRANCH_NAME}}-${{ matrix.chunk }}-${{ matrix.perf }}-${{ matrix.node_version }}
+          path: ${{env.OUTPUT_TEST_DIR}}
 
       - name: Add to job summary
         if: always()
         run: |
-          echo "### Test Results for Unit Tests Chunk ${{ matrix.chunk }}" >> $GITHUB_STEP_SUMMARY
-          cat profiling.md >> $GITHUB_STEP_SUMMARY
+          echo "### Test Results for Unit Tests Chunk ${{ matrix.chunk }}" >> "$GITHUB_STEP_SUMMARY"
+          cat profiling.md >> "$GITHUB_STEP_SUMMARY"
 
   Build-And-Test-Server-Unit-Tests:
     name: Build-And-Test-Server (Unit tests)
@@ -229,15 +300,15 @@ jobs:
           npm run e2e:prepare-server
 
       - name: Execute E2E tests
-        run: npm run test:e2e
-
+        run:  npm run test:e2e
       - name: Upload E2E test artifacts
         uses: actions/upload-artifact@v4
         continue-on-error: true
         if: always()
         with:
           if-no-files-found: ignore
           name: e2e-tests-report
+          # playwrite data
           path: tests/report/
           retention-days: 30
 

.github/workflows/changelog-entry.yml

@@ -1,9 +1,10 @@
 name: Check Changelog for changes
 on:
-  pull_request:
-    types: [assigned, opened, synchronize, reopened, labeled, unlabeled]
-    branches:
-      - main
+  workflow_dispatch:
+#  pull_request:
+#    types: [assigned, opened, synchronize, reopened, labeled, unlabeled]
+#    branches:
+#      - main
 jobs:
   Check-Changelog:
     name: Check Changelog Action

.github/workflows/doc.yml

@@ -1,8 +1,9 @@
 name: o1js typedoc
 on:
-  push:
-    branches:
-      - main
+  workflow_dispatch:
+#  push:
+#    branches:
+#      - main
 
 jobs:
   Build-Doc:

.github/workflows/live-tests.yml

@@ -1,11 +1,11 @@
 name: Test o1js against lightnet
 on:
-  push:
-    branches:
-      - main
-  pull_request:
-    branches:
-      - main
+#  push:
+#    branches:
+#      - main
+#  pull_request:
+#    branches:
+#      - main
   workflow_dispatch: {}
 
 jobs:

.github/workflows/pkg-pr-new-publish.yml

@@ -4,9 +4,9 @@
 
 name: Continuous releases on pkg-pr-new
 on:
-  push:
-    branches:
-      - main
+#  push:
+#    branches:
+#      - main
   workflow_dispatch: {}
 
 jobs:

.github/workflows/release.yml

@@ -11,8 +11,8 @@ name: Version Bump
 
 on:
   workflow_dispatch: # Allow to manually trigger the workflow
-  schedule:
-    - cron: '0 0 * * 2' # At 00:00 UTC every Tuesday
+#  schedule:
+#    - cron: '0 0 * * 2' # At 00:00 UTC every Tuesday
 
 jobs:
   version-bump:

.gitignore

@@ -13,3 +13,58 @@ src/config.mlh
 .direnv
 .rustup
 result
+isolate*-v8.log
+CPU*.cpuprofile
+Heap*heapprofile
+<<<<<<< HEAD
+=======
+# -*- mode: gitignore; -*-
+*~
+\#*\#
+/.emacs.desktop
+/.emacs.desktop.lock
+*.elc
+auto-save-list
+tramp
+.\#*
+
+# Org-mode
+.org-id-locations
+*_archive
+
+# flymake-mode
+*_flymake.*
+
+# eshell files
+/eshell/history
+/eshell/lastdir
+
+# elpa packages
+/elpa/
+
+# reftex files
+*.rel
+
+# AUCTeX auto folder
+/auto/
+
+# cask packages
+.cask/
+dist/
+
+# Flycheck
+flycheck_*.el
+
+# server auth directory
+/server/
+
+# projectiles files
+.projectile
+
+# directory configuration
+.dir-locals.el
+
+# network security
+/network-security.data
+
+>>>>>>> f7809db87 (perf recording)

run

@@ -1 +1,4 @@
-node --enable-source-maps --stack-trace-limit=1000 src/build/run.js $@
+node --cpu-prof --expose-gc --cpu-prof-dir tests/report/profile-data --enable-source-maps --stack-trace-limit=1000 src/build/run.js $@
+
+node --heap-prof --expose-gc  --enable-source-maps --stack-trace-limit=1000 src/build/run.js $@
+node --prof --expose-gc  --enable-source-maps --stack-trace-limit=1000 src/build/run.js $@

src/lib/provable/test/keccak.unit-test.ts → src/lib/provable/test/keccak-256.unit-test.ts

@@ -38,7 +38,9 @@ const testImplementations = {
   },
 };
 
-const lengths = [256, 384, 512] as const;
+const lengths = [256
+		 //, 384, 512
+		] as const;
 
 // EQUIVALENCE TESTS AGAINST REF IMPLEMENTATION