Merge pull request #1814 from o1-labs/fix/circuit-string-length

Fix CircuitString length calculation
o1-labs · Sep 9, 2024 · 81dd73c · 81dd73c
2 parents d446403 + 6e8bc95
commit 81dd73c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/lib/provable/string.ts b/src/lib/provable/string.ts
@@ -88,7 +88,7 @@ class CircuitString extends Struct(RawCircuitString) {
       let isNull = this.values[i].isNull();
       mask[i] = isNull.and(wasntNullAlready);
       wasntNullAlready = isNull.not().and(wasntNullAlready);
-      length.add(wasntNullAlready.toField());
+      length = length.add(wasntNullAlready.toField());
     }
     // mask has length n+1, the last element is true when `this` has no null char
     mask[n] = wasntNullAlready;

diff --git a/src/lib/provable/test/string.unit-test.ts b/src/lib/provable/test/string.unit-test.ts
@@ -150,6 +150,18 @@ describe('Circuit String', () => {
     });
   });
 
+  describe('#length', () => {
+    test('length', async () => {
+      const str1 = CircuitString.fromString('abcd');
+      expect(str1.length()).toEqual(Field(4));
+
+      await Provable.runAndCheck(() => {
+        const str1 = CircuitString.fromString('abcd');
+        expect(str1.length()).toEqual(Field(4));
+      });
+    });
+  });
+
   /*   describe('CircuitString8', async () => {
     test('cannot create more than 8 chars', () => {
       expect(() => {