Allow non-pure provable types as inputs/outputs in zkprogram #1828
+158
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ProvablePure to Provable
…m ProvablePure to Provable
…gram state for zk programs
…or clarity and consistency with its purpose
…e for better clarity and consistency in naming conventions
…r setting auxiliary output values
…ram function for future use and flexibility
…t for consistency and clarity
…r clarity and consistency
…to 'setAuxiliaryInput' for consistency
…f996b6ac35373dc27084ef
…putExists for clarity
…avoid unnecessary operations
…ure auxilary data was updated in-circuit
…ux data made in circuit
…e for additional input data support
…e auxData parameter for additional flexibility and reusability
…prove code readability and maintainability
Trivo25
approved these changes
Nov 2, 2024
| await MyProgram.compile(); | ||
| console.log('compile done'); | ||
|
|
||
| let input = new MyStruct({ label: 'input', value: Field(5) }); |
There was a problem hiding this comment.
this is missing the description property
| console.log('proof', proof); | ||
|
|
||
| assert(ok, 'proof not valid!'); | ||
| // assert(proof.publicOutput.label === 'inCircuit'); |
There was a problem hiding this comment.
once the PR is ready we should re-enable this check
src/lib/proof-system/zkprogram.ts
Outdated
| @@ -161,12 +161,30 @@ const FeatureFlags = { | |||
| }; | |||
|
|
|||
| function createProgramState() { | |||
| let nonPureDataCache: Map<string, any[]> = new Map(); | |||
There was a problem hiding this comment.
we could just reuse the method cache for this too, would make it a bit cleaner but we would have to differenciate between nonpure auxiliary data and the auxiliary output its currently keeping track. both are valid imo
src/lib/proof-system/zkprogram.ts
Outdated
| result = (await func(input, ...finalArgs)) as any; | ||
| } | ||
|
|
||
| console.log('result input', result); | ||
| if (result.publicOutput) { |
There was a problem hiding this comment.
this should probably be result?.publicOutput since result is unfornately typed
Trivo25
requested changes
Nov 2, 2024
…ld from MyStruct and add assertion to check for 'label' value in proof.publicOutput
…to use optional chaining for improved readability and null safety
…log statement for 'proof' variable
|
@ymekuria please rebase too |
…ean up code and improve readability
…NonPureOutput to improve code clarity and type safety
…input and output variables to be more descriptive and accurate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
ZkProgramto allow non-pure provable types as inputs and outputs.Addresses #1675
Impact
Currently only pure provable types can be used as inputs and outputs to a
ZkProgram. This PR improves the DX with changes that allow a developer to update rich provable types like aIndexedMerkleMapor aMerkleListin aZkProgram.