Use proof-systems master #1942
Use proof-systems master #1942
Conversation
| @@ -25,6 +25,8 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
| - Method for optional types to assert none https://github.com/o1-labs/o1js/pull/1922 | |||
| - Increased maximum supported amount of methods in a `SmartContract` or `ZkProgram` to 30. https://github.com/o1-labs/o1js/pull/1918 | |||
| - Expose low-level conversion methods `Proof.{_proofToBase64,_proofFromBase64}` https://github.com/o1-labs/o1js/pull/1928 | |||
| - Improve usage of branches of proof-systems. Mina uses only the master branch | |||
| from now. https://github.com/o1-labs/o1js/pull/1942 | |||
There was a problem hiding this comment.
I don't think we need this for a markdown-only change
There was a problem hiding this comment.
There is also an update of the bindings.
| @@ -1,22 +1,31 @@ | |||
| # o1js README-dev | |||
|
|
|||
| o1js is a TypeScript framework designed for zk-SNARKs and zkApps on the Mina blockchain. | |||
| o1js is a TypeScript framework designed for zk-SNARKs and zkApps on the Mina | |||
There was a problem hiding this comment.
Are these line-length diffs intentional, or just your local IDE settings?
There was a problem hiding this comment.
These are intentional, yes.
I added these changes in two independent commits that can be removed if there is a strong opinion on not enforcing a limit of 80 characters.
It is quite commonly accepted to keep 80 characters as a limit, not only for historical reasons, but also because it is easier to go through files in modern editors too when we have multiple buffers open on the same screen.
There was a problem hiding this comment.
(but also my editor is configured to make it relatively automatic when I open a file)
|
Moving back in draft. It seems I did not update the bindings correctly. |
dannywillems
force-pushed
the
dw/use-proof-systems-master
branch
2 times, most recently
from
74ccc2f to
9ea496f
Compare
Use commit which uses proof-systems/master instead of proof-systems/develop, including additional changes to make the Mina codebase compatible.
Update bindings after checking out to mina branch that uses proof-systems/master
dannywillems
force-pushed
the
dw/use-proof-systems-master
branch
from
9ea496f to
73a98a2
Compare
See MinaProtocol/mina#16405 for additional context.