Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AssImp 5.4.3: Universal Scene Description (USD) #264

Merged
merged 19 commits into from
Oct 2, 2024
Merged

AssImp 5.4.3: Universal Scene Description (USD) #264

merged 19 commits into from
Oct 2, 2024

Conversation

AMZN-Gene
Copy link
Contributor

@AMZN-Gene AMZN-Gene commented Sep 24, 2024 •
edited
Loading

Migrating to AssImp 5.4.3

  • Enabling USD (AssImp's USD imports TinyUSDZ which compiles with warnings, so had to turn off compiler warnings as errors)
  • Disable building tools as they aren't required (assimp.exe)
  • Making sure installation scripts works. Build scripts and installer scripts were looking in different folders (src vs build folder)
    • Long term it would be better update scripts built into a separate "build" folder.

image

@AMZN-Gene
AssImp explicitly enable USD. USD is turned off by default because th…
88cf046 
…e tinyUSD library is full of compiler warnings which fail AssImp's automated testing

Signed-off-by: AMZN-Gene <genewalt@amazon.com>
@AMZN-Gene
Assimp 5.4.3 with USD support
862b0d6 
Signed-off-by: AMZN-Gene <genewalt@amazon.com>
@AMZN-Gene
Adding comment as to why compile with warnings not treated as error. …
eca28ae 
…Assimp's USD support requires compiling TinyUSDZ, which contains compile warnings

Signed-off-by: AMZN-Gene <genewalt@amazon.com>
@AMZN-Gene AMZN-Gene changed the title AssImp USD Support AssImp 5.4.3: USD Support Sep 24, 2024
@AMZN-Gene
Fix assimp mac package to build. The script was trying to build in th…
428a3ab 
…e wrong build folder

Signed-off-by: Gene Walters <genewalt@amazon.com>
@AMZN-Gene
Adding code comment for why we turn off warnings as errors when build…
2d5bc8f 
…ing assimp

Signed-off-by: AMZN-Gene <genewalt@amazon.com>
@AMZN-Gene
Pulling latest
a967217 
Signed-off-by: AMZN-Gene <genewalt@amazon.com>
@AMZN-Gene
Using python-pip to pull cmake for assimp's dockerfile. Assimp requir…
4072b7e 
…es cmake 3.22, but Ubuntu 20.04 apt-get only provides 3.16

Signed-off-by: Gene Walters <genewalt@amazon.com>
@AMZN-Gene
Assimp build script updates. Installer expects the build directly in …
181ef4f 
…the src folder

Signed-off-by: Gene Walters <genewalt@amazon.com>
@AMZN-Gene
Turning off some specific warnings as errors for assimp package. Assi…
2c57096 
…mp doesnt have any warnings, but a dependency on TinyUSDZ has warnings

Signed-off-by: Gene Walters <genewalt@amazon.com>
@AMZN-Gene
Assimp package add aarch64 to build list on linux-x86 nodes (via Docker)
70fed63 
Signed-off-by: AMZN-Gene <genewalt@amazon.com>
@AMZN-Gene
Updating assimp windows build cmd to install direct x; this is for th…
f34ed85 
…e build node

Signed-off-by: AMZN-Gene <genewalt@amazon.com>
@AMZN-Gene
Using Chocolately instead of manual download to install directX on As…
ec32530 
…simp 3p build machine

Signed-off-by: AMZN-Gene <genewalt@amazon.com>
@AMZN-Gene
Using Chocolately to install directX sdk on Assimp 3p build machine
3ebfc59 
Signed-off-by: AMZN-Gene <genewalt@amazon.com>
@AMZN-Gene
Turn off building assimp tools; only the assimp libraries are require…
9cbdaf0 
…d by O3DE

Signed-off-by: AMZN-Gene <genewalt@amazon.com>
@AMZN-Gene
Removing debug print statement after building assimp on MacOS
fce7856 
Signed-off-by: AMZN-Gene <genewalt@amazon.com>
@AMZN-Gene
Turning off parallel builds on Windows. The build node is failing to …
14fa201 
…compile because error C1041 (multiple CL.EXE write to the same .PDB file)

Signed-off-by: AMZN-Gene <genewalt@amazon.com>
@AMZN-Gene
Turn off warnings as errors on windows
afe864f 
Signed-off-by: AMZN-Gene <genewalt@amazon.com>
@AMZN-Gene
Explicitely generate using Visual Studio 17; otherwise the build node…
86e85b7 
… was using Ninja and running into compiler errors

Signed-off-by: AMZN-Gene <genewalt@amazon.com>
@AMZN-Gene AMZN-Gene changed the title AssImp 5.4.3: USD Support AssImp 5.4.3: Universal Scene Description (USD) Oct 1, 2024
@AMZN-Gene
Turn off single thread compile for Windows (allow parallel). I only n…
a63ad17 
…eeded this when compiling with Ninja, but now using Visual Studio.

Signed-off-by: AMZN-Gene <genewalt@amazon.com>
@AMZN-Gene AMZN-Gene merged commit 11c082c into o3de:main Oct 2, 2024
14 checks passed
@AMZN-Gene AMZN-Gene deleted the AssImp_USD branch October 2, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadams3 gadams3 gadams3 approved these changes

@moudgils moudgils moudgils approved these changes

@nick-l-o3de nick-l-o3de Awaiting requested review from nick-l-o3de

@spham-amzn spham-amzn Awaiting requested review from spham-amzn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AMZN-Gene @moudgils @gadams3