Restore grafana.db selinux context after engine-restore #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore proper selinux context for /var/lib/grafana/grafana.db when restoring from backup created by engine-backup. Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
requested review from
ahadas,
bennyz,
emesika,
michalskrivanek,
oliel,
sgratch,
smelamud,
didib and
ljelinkova
as code owners
mwperina
requested review from
sandrobonazzola
and removed request for
smelamud,
ljelinkova,
bennyz,
emesika,
sgratch and
oliel
|
/ost basic-suite-master el9stream |
didib
reviewed
Jan 30, 2024
| @@ -1703,7 +1703,8 @@ restoreSQLiteDB() { | |||
| chmod 0750 "${db_dir}" 2>> "${LOG}" || logdie "chmod failed" | |||
| chown "${dir_owner}" "${db_dir}" 2>> "${LOG}" || output "Warning: ${dir_owner} user or group missing" | |||
| fi | |||
| cp -a "${backupfile}" "${db_file}" 2>> "${LOG}" || "cp failed" | |||
| @@ -1703,7 +1703,8 @@ restoreSQLiteDB() { | |||
| chmod 0750 "${db_dir}" 2>> "${LOG}" || logdie "chmod failed" | |||
| chown "${dir_owner}" "${db_dir}" 2>> "${LOG}" || output "Warning: ${dir_owner} user or group missing" | |||
| fi | |||
| cp -a "${backupfile}" "${db_file}" 2>> "${LOG}" || "cp failed" | |||
| cp -a "${backupfile}" "${db_file}" 2>> "${LOG}" || logdie "cp failed" | |||
| restorecon "${db_file}" || log "Restoring selinux context failed" | |||
There was a problem hiding this comment.
Thanks. LGTM. Looks like a bug - I wonder how come it wasn't reported years ago. Perhaps it only happens if the parent dir is created manually with a non-default context, or something like that - no idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore proper selinux context for /var/lib/grafana/grafana.db when
restoring from backup created by engine-backup.
Signed-off-by: Martin Perina mperina@redhat.com