Default values for ovirt-img add_sub_command method added #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do the reviews over the same commit, to have a clean commit history. In this case, you can squash the commits with an interactive rebase: And then change No need to open a new PR for changes. If you have any issue, let me know! |
sri-srikanth
force-pushed
the
add_sub_command_default_values
branch
from
b1122f5
to
746ecea
Compare
|
Squashed :) |
|
The change looks good, but could you please change the commit text with the one you used for the PR? Including the |
aesteve-rh
force-pushed
the
add_sub_command_default_values
branch
from
746ecea
to
9f0db8b
Compare
ovirt-img add_sub_command method's help and func parameters now have default values that are set to "help" and a no-op lambda func, respectively, to simplify method usage in test cases. Method calls referencing the add_sub_command method have also been cleaned up accordingly. Fixes: oVirt#120 Signed-off-by: sri-srikanth <srivatsansrikanth2018@gmail.com>
aesteve-rh
force-pushed
the
add_sub_command_default_values
branch
from
9f0db8b
to
ad3af85
Compare
aesteve-rh
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ovirt-img add_sub_command method's help and func parameters now have
default values that are set to "help" and a no-op lambda func,
respectively, to simplify method usage in test cases. Method calls
referencing the add_sub_command method have also been cleaned up
accordingly.
Fixes #120
Signed-off-by: sri-srikanth srivatsansrikanth2018@gmail.com