Add a starter relational DB source implementation #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
source/sink so they aren't duplicating work. Change the source sink constructor signatures to make this possible. Also change docstrings to help readers understand the constructor interfaces.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## relational-data-sink #590 +/- ##
=====================================================
Coverage 87.39% 87.39%
=====================================================
Files 155 155
Lines 18107 18107
=====================================================
Hits 15824 15824
Misses 2283 2283 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some foundational work to move some aspects of table schema creation out of the sink and into external functions which can be called by source, sink, or store, whoever needs it. This is necessary to write the source. Also update the store implementation to do schema creation once and pass the table metadata to source/sink, to avoid duplicating work. The source/sink retain the ability to do this themselves, if they are used independently of the store.