Bump Go to 1.23.2 #5854
Merged
Bump Go to 1.23.2 #5854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
jberci
force-pushed
the
jberci/feature/go
branch
2 times, most recently
from
ddbe73d
to
59cf805
Compare
jberci
force-pushed
the
jberci/feature/go
branch
2 times, most recently
from
58489fb
to
f63fce6
Compare
|
We should probably wait for golang/go#69312 to get fixed in 1.23.x as it impacts libp2p. |
How did you figure this out? Was it due to failed tests, or are you tracking issues of all our dependencies? 🤔 |
|
Yeah, I'm tracking issues and changelogs of some of our key dependencies :) |
|
Looks like the issue has been fixed in Go 1.23.2. |
jberci
force-pushed
the
jberci/feature/go
branch
from
f63fce6
to
4ef7753
Compare
peternose
reviewed
Oct 10, 2024
jberci
force-pushed
the
jberci/feature/go
branch
from
4ef7753
to
95d47b5
Compare
jberci
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
peternose
approved these changes
Oct 10, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5854 +/- ##
==========================================
- Coverage 65.06% 64.74% -0.32%
==========================================
Files 624 627 +3
Lines 63923 64292 +369
==========================================
+ Hits 41592 41627 +35
- Misses 17467 17756 +289
- Partials 4864 4909 +45 ☔ View full report in Codecov by Sentry. |
kostko
approved these changes
Oct 11, 2024
jberci
force-pushed
the
jberci/feature/go
branch
from
95d47b5
to
b740645
Compare
jberci
force-pushed
the
jberci/feature/go
branch
from
b740645
to
96ae86d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5826