This repository has been archived by the owner on Nov 23, 2021. It is now read-only.
Push changes submittted in PR#442 to a new branch under develop-2.3.0 #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ranch 'sampleValueCreation' under develop-2.3.0'
…moveTODOs' under the branch 'develop-2.3.0'
… under develop-2.3.0
|
Can one of the admins verify this patch? |
|
@maihacke , I have submitted the code that was submitted as part of PR #442 to a new branch under the branch 'develop-2.3.0' and created this pull request. If you see the history , Travis CI build is failing and the reason for that is the JUNIT 'OfferImportJobTest' is failing. This failure doesn't occur in my system when I do 'mvn clean install' of oasp4j project. But , I am able to reproduce this failure when I launch this test alone as 'Run As -> Junit Test' in Eclipse of devonfw distribution. Please let me know if you have any clue on this ? Once these issues are resolved I will merge this code onto the branch develop-2.3.0 Thanks, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push changes submittted in PR#442 to a new branch under develop-2.3.0