fix: improve error reports

oat-sa · Feb 25, 2025 · 2cd8187 · 2cd8187
1 parent e192069
commit 2cd8187
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/model/Export/AbstractQTIItemExporter.php b/model/Export/AbstractQTIItemExporter.php
@@ -175,6 +175,11 @@ public function export($options = [])
                 $replacementList[$assetUrl] = '';
                 $report->setMessage($e->getMessage());
                 $report->setType(Report::TYPE_ERROR);
+            } catch (FilesystemException $exception) {
+                $replacementList[$assetUrl] = '';
+                $report->setMessage($exception->getMessage());
+                $report->setType(Report::TYPE_ERROR);
+                return $report;
             }
         }
 

diff --git a/model/Export/QTIPackedItemExporter.php b/model/Export/QTIPackedItemExporter.php
@@ -29,9 +29,9 @@
 use oat\taoQtiItem\model\qti\Service;
 use core_kernel_classes_Resource;
 use oat\taoQtiTest\models\classes\metadata\GenericLomOntologyExtractor;
-use oat\taoQtiTest\models\classes\metadata\MetadataLomService;
 use ZipArchive;
 use DOMDocument;
+use oat\oatbox\reporting\Report;
 use tao_helpers_Uri;
 use taoItems_models_classes_TemplateRenderer;
 use tao_helpers_Display;
@@ -72,7 +72,7 @@ public function export($options = [])
     {
         if (!$this->containsItem()) {
             $report = parent::export($options);
-            if ($report->getType() === \common_report_Report::TYPE_ERROR || $report->containsError()) {
+            if ($report->getType() === Report::TYPE_ERROR || $report->containsError()) {
                 return $report;
             }
             try {
@@ -82,12 +82,12 @@ public function export($options = [])
                 }
                 $this->exportManifest($options, $exportResult);
             } catch (ExportException $e) {
-                $report->setType(\common_report_Report::TYPE_ERROR);
+                $report->setType(Report::TYPE_ERROR);
                 $report->setMessage($e->getUserMessage());
             }
             return $report;
         }
-        return \common_report_Report::createSuccess();
+        return Report::createSuccess();
     }
 
     /**