Rename executable to trashy (#104) #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since trashy no longer supports `trash <PATH> ...` and has given up on being a drop-in trash-cli replacement, the executable name `trash` is only a hinderance to greater adoption because it conflicts with the trash-cli executable of the same name. Giving the executable a unique name allows both programs to be installed without issue and also allows programs that wish to shell out to external commands for trashing files to support trashy by simply checking if an executable named `trashy` is present. Before this change, these programs had to check the output of the user's `trash` command to determine if it was from trash-cli or trashy.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since trashy no longer supports
trash <PATH> ...and has given up on being a drop-in trash-cli replacement, the executable nametrashis only a hinderance to greater adoption because it conflicts with the trash-cli executable of the same name. Giving the executable a unique name allows both programs to be installed without issue and also allows programs that wish to shell out to external commands for trashing files to support trashy by simply checking if an executable namedtrashyis present. Before this change, these programs had to check the output of the user'strashcommand to determine if it was from trash-cli or trashy.Fixes #104