enable HAVE_STRUCT_CMSGHDR when building with mingw #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anyc
force-pushed
the
develop
branch
3 times, most recently
from
deb2768
to
bfd7468
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building libcoap with mingw, I noticed that coap_session_get_ifindex() always return zero. In the code, it looks like this is always set to zero if HAVE_STRUCT_CMSGHDR is unset in line:
libcoap/src/coap_io.c
Line 1165 in 7d5e5f3
Wouldn't -1 be a better value to indicate an undefined value?
If libcoap is built for Windows without mingw, HAVE_STRUCT_CMSGHDR is always defined. In this PR, I removed the special handling of mingw, added a few aliases and the code seems to work with HAVE_STRUCT_CMSGHDR defined and mingw.