Cleanup building header files for different OS #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'make distclean' removes header files built from the .in files, which means that they are not available for different OS builds. The same is true for CMakeLists.txt. Remove the need for the .in files and update for libcoap revisions by using a new script scripts/fix_version.sh created from scripts/fix_version.sh.in. CI has been updated to check revisions have been updated in the appropriate places. Do not remove libcoap-3.sym and libcoap-3.map when doing 'make distclean' as they are git tracked files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'make distclean' removes header files built from the .in files, which means that they are not available for different OS builds.
The same is true for CMakeLists.txt.
Remove the need for the .in files and update for libcoap revisions by using a new script scripts/fix_version.sh created from scripts/fix_version.sh.in.
CI has been updated to check revisions have been updated in the appropriate places.
Do not remove libcoap-3.sym and libcoap-3.map when doing 'make distclean' as they are git tracked files.