Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contiki-NG: Fix coap_resolve_address_info #1496

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

kkrentz
Copy link
Contributor

@kkrentz kkrentz commented Aug 12, 2024

addr_ip was declared as a pointer, but sometimes not used in this manner.

@mrdeep1
Copy link
Collaborator

mrdeep1 commented Aug 12, 2024

Thanks for this fix.

It would be great if coap_resolve_address_info() could also resolve DNS provided names, but I have no idea as to how to do that in Contiki-NG.

@kkrentz
Copy link
Contributor Author

kkrentz commented Aug 12, 2024

Contiki-NG provides the resolv module. However, it may return RESOLV_STATUS_RESOLVING and provide the result later. This makes it difficult to use it here. Another complication is that modules are not usually compiled and only added on demand.

@mrdeep1
Copy link
Collaborator

mrdeep1 commented Aug 12, 2024

Thanks for the feedback re resolv. I'll ignore doing this for now.

@mrdeep1 mrdeep1 merged commit 7dab8f6 into obgm:develop Aug 12, 2024
31 checks passed
@kkrentz kkrentz deleted the resolve-pr branch September 17, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants