Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge to master for v0.5.2 #119

Merged
merged 7 commits into from
Aug 9, 2023
Merged

Merge to master for v0.5.2 #119

merged 7 commits into from
Aug 9, 2023

Commits on Aug 2, 2023

  1. Change Index and TextPos to use enum constructors for extents

    The static member variable version was flawed as it suffered from SIOF,
    since TextPos' static END made use of Index's static LAST. Often, END
    would be initialized before LAST resulting in END being invalid/garbage.
    
    This approach, while slightly less terse, prevents that issue.
    
    The only other option is to use static member functions that return a
    type constructed to be that extent, which would enact RAII.
    
    The interface would look like: Index32::last();
    instead of Index32(Index32::Last).
    oblivioncth committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    695b08c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0db75b1 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Rewrite TextPos comparisons using C++20 guidance of only == and <=>

    This also fixes ambiguity warnings introduced with C++20 due to the old
    operators not having proper const correctness.
    oblivioncth committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    e59355e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b49f6e6 View commit details
    Browse the repository at this point in the history
  3. Fix Index/TextPos return type

    Needs to be explicit so they can be used before they are defined in
    other translation units.
    oblivioncth committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    565d252 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Configuration menu
    Copy the full SHA
    90d0e73 View commit details
    Browse the repository at this point in the history
  2. Bump

    oblivioncth committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    7d530be View commit details
    Browse the repository at this point in the history