Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix code sample for manual HTTP requests #1122

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

mattsains
Copy link
Contributor

fix manual HTTP code sample

Why are we making this change?

This is a very minor change but it might throw users who are less familiar with reqwest for a loop

What effects does this change have?

The json member in reqwest's response is a function and needs to be called, not accessed.

fix manual HTTP code sample
@mattsains mattsains changed the title docs: Fix code sample for manual HTTP requests docs: fix code sample for manual HTTP requests Jan 9, 2025
Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for cynic-querygen-web canceled.

Name Link
🔨 Latest commit d58858e
🔍 Latest deploy log https://app.netlify.com/sites/cynic-querygen-web/deploys/677f39835cf2fa0009b05b4c

@obmarg
Copy link
Owner

obmarg commented Jan 9, 2025

Thanks @mattsains - I'm sure I copied this code out of a running example so not sure how that mistake happened 😓

@obmarg obmarg enabled auto-merge (squash) January 9, 2025 10:54
@obmarg obmarg merged commit d1c2359 into obmarg:main Jan 9, 2025
6 checks passed
@mattsains mattsains deleted the mattsains-docs-fix branch January 9, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants