Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass of cynic-parser #803

Merged
merged 31 commits into from
Jan 7, 2024
Merged

First pass of cynic-parser #803

merged 31 commits into from
Jan 7, 2024

Conversation

obmarg
Copy link
Owner

@obmarg obmarg commented Jan 7, 2024

Why are we making this change?

There are parts of the latest spec that graphql-parser doesn't support, so I want to replace it with an alternative.

Other options out there that I'm aware of:

  • async-graphql-parser would work but its AST is quite annoying to work with, and last time I tested it was slower than graphql-parser.
  • apollo-parser continues on failure to parse, which is nice but means there are a lot of Options in its AST. I don't particularly want that behaviour so that's out.
  • apollo-compiler would probably make apollo-parser workable, but feels like too heavy a dependency for my needs.

So it looks like I might write my own. Also, it'll be fun.

What effects does this change have?

Adds the first pass of a parser for GraphQL type system documents.

@obmarg obmarg changed the title Cynic parser 2 larlpop First pass of cynic-parser Jan 7, 2024
Copy link

netlify bot commented Jan 7, 2024

Deploy Preview for cynic-querygen-web canceled.

Name Link
🔨 Latest commit 2814025
🔍 Latest deploy log https://app.netlify.com/sites/cynic-querygen-web/deploys/659acbdc6d18c3000819af31

@obmarg obmarg merged commit dab97cb into main Jan 7, 2024
6 checks passed
@obmarg obmarg deleted the cynic-parser-2-larlpop branch January 7, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant