-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First pass of cynic-parser #803
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cynic-querygen-web canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we making this change?
There are parts of the latest spec that
graphql-parser
doesn't support, so I want to replace it with an alternative.Other options out there that I'm aware of:
async-graphql-parser
would work but its AST is quite annoying to work with, and last time I tested it was slower thangraphql-parser
.apollo-parser
continues on failure to parse, which is nice but means there are a lot ofOption
s in its AST. I don't particularly want that behaviour so that's out.apollo-compiler
would probably makeapollo-parser
workable, but feels like too heavy a dependency for my needs.So it looks like I might write my own. Also, it'll be fun.
What effects does this change have?
Adds the first pass of a parser for GraphQL type system documents.