Feat(anomaly-connector) Log Volume Anomaly Connector #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BominRahmani
force-pushed
the
feat/log-volume-anomaly-processor
branch
from
bfceebb to
4ae03cf
Compare
dpaasman00
force-pushed
the
release/v1.68.0
branch
from
b16d351 to
bf09cd9
Compare
BominRahmani
force-pushed
the
feat/log-volume-anomaly-processor
branch
from
db965bf to
cbff773
Compare
BominRahmani
force-pushed
the
feat/log-volume-anomaly-processor
branch
from
82811b3 to
acd6c8f
Compare
antonblock
requested changes
Jan 8, 2025
BominRahmani
force-pushed
the
feat/log-volume-anomaly-processor
branch
from
826f8a1 to
53da5a1
Compare
antonblock
requested changes
Jan 13, 2025
| MaxWindowAge time.Duration `mapstructure:"max_window_age"` | ||
| // Thresholds for anomaly detection | ||
| ZScoreThreshold float64 `mapstructure:"zscore_threshold"` | ||
| MADThreshold float64 `mapstructure:"mad_threshold"` |
There was a problem hiding this comment.
Please add a comment explaining what this is
|
|
||
| // Validate checks whether the input configuration has all of the required fields for the processor. | ||
| // An error is returned if there are any invalid inputs. | ||
| func (config *Config) Validate() error { |
There was a problem hiding this comment.
Add tests enforcing these error cases
| } | ||
|
|
||
| // Helper to verify anomaly record | ||
| func verifyAnomalyRecord(t *testing.T, record plog.LogRecord, expectedType string, expectedRate float64) { |
| } | ||
|
|
||
| // Helper to get the first log record from LogsSink | ||
| func getFirstLogRecord(t *testing.T, sink *consumertest.LogsSink) plog.LogRecord { |
| // takeSample calculates and stores a new rate sample | ||
| func (d *Detector) takeSample(now time.Time) { | ||
| duration := now.Sub(d.currentBucket.start).Minutes() | ||
| if duration < (1.0 / 60.0) { |
There was a problem hiding this comment.
It might make sense to put this in a commented const to be clearer
djaglowski
reviewed
Jan 16, 2025
djaglowski
reviewed
Jan 16, 2025
BominRahmani
force-pushed
the
feat/log-volume-anomaly-processor
branch
from
5953b43 to
5f49322
Compare
djaglowski
reviewed
Jan 29, 2025
djaglowski
reviewed
Jan 31, 2025
BominRahmani
force-pushed
the
feat/log-volume-anomaly-processor
branch
from
ce33e15 to
56673f7
Compare
djaglowski
approved these changes
Feb 3, 2025
BominRahmani
force-pushed
the
feat/log-volume-anomaly-processor
branch
from
56673f7 to
4c5a1fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
The following PR introduces the Log volume Anomaly connector.
Checklist