Skip to content

Commit

Permalink
Use the non-sane version of newXMLHttpRequest
Browse files Browse the repository at this point in the history
This is because that version has been created to explicitly mask the
errors on the js side, making them surface on the haskell side instead,
see:

reflex-frp/reflex-dom#369

While in this case the bug is not related to port numbers, I was
wondering if the core mechanism of not letting exceptions show up is the
same.
  • Loading branch information
meditans committed Feb 7, 2022
1 parent fe8978f commit b4f417e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions frontend/src/Frontend/Network/NodeInfo.hs
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,7 @@ runReq
-> m (Either XhrException XhrResponse)
runReq (SafeXhrRequest req) = do
resp <- newEmptyMVar
void $ newXMLHttpRequestWithErrorSane req (liftIO . putMVar resp)
takeMVar resp
void $ newXMLHttpRequestWithError req (liftIO . putMVar resp)


-- Sane version of newXMLHttpRequestWithError: Report all errors via callback,
Expand Down
2 changes: 1 addition & 1 deletion mac/src/Mac.hs
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ redirectPipes ps m = bracket setup hClose $ \r -> Async.withAsync (go r) $ \_ ->
go r = forever $ hGetLine r >>= logToSyslog LevelInfo . toLogStr

main :: IO ()
main = sysloggedMain "Kadena Chainweaver" . redirectPipes [stderr, stdout] $
main = -- sysloggedMain "Kadena Chainweaver" . redirectPipes [stderr, stdout] $
main' ffi mainBundleResourcePath runMac

runMac
Expand Down

0 comments on commit b4f417e

Please sign in to comment.