Make frontend-api integration optional #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the "_ENABLED" suffix on options. The advantage of this is it makes more sense and it's easier to work with from CMake. The script will now check to see if that EXPERIMENTAL_SHARED_TEXTURE_SUPPORT is true. If it is, it sets the enabled variable which can then be used in code correctly with the need to define macros that hope to catch the value of that option. This way, any false or true value that cmake knows will correctly work. If one is given to cmake that it doesn't understand it will correctly tell the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relies on to avoid a merge conflict #127
This is makes a mildly controversial change that allows the obs-frontend-api to be optional but enables it by default.
This replaces #122 with a cleaner changeset.