Disable Bluetooth support #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The integrated browser is not supposed to be a fully featured web browser, but rather provide support for modern web standards that can be integrated neatly into an overlay or the UI via a panel. WebBluetooth requires additional system permissions (especially on macOS) and can potentially cause OBS to crash if those permissions are denied. That's not ideal either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The integrated browser is not supposed to be a fully featured web browser, but rather provide support for modern web standards that can be integrated neatly into an overlay or the UI via a panel.
WebBluetooth requires additional system permissions (especially on macOS) and can potentially cause OBS to crash if those permissions are denied or missing. That's not ideal either.
Motivation and Context
@gxalpha ran into a crash on their local builds when certain browser panels attempted to request Bluetooth permission because the
Info.plistfor OBS does not list Bluetooth. CI builds (at the moment) seem to query the OS correctly and a system-level request Bluetooth permission, however there is no reason we can think of why the browser currently should have access to Bluetooth.How Has This Been Tested?
Types of changes
Checklist: