-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update clang-format to 17.0.3 and port clang-format actions from obs-studio #457
Conversation
20cb32a
to
0eac1eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output of this PR matches what I expected when I originally performed formatting with the wider column layout.
0eac1eb
to
9d46dce
Compare
I've rebased this PR to ensure it still passes with the other changes to master. Will leave up to @RytoEX to squash as necessary & merge. After this PR is merged, it'd also be worth committing a |
Co-authored-by: PatTheMav <PatTheMav@users.noreply.github.com>
This is so we can update clang-format to 17 or newer. Co-authored-by: PatTheMav <PatTheMav@users.noreply.github.com>
Co-authored-by: PatTheMav <PatTheMav@users.noreply.github.com>
Also port clang-format settings from obs-studio. Use these settings for consistency with obs-studio code style.
9d46dce
to
9ab4e77
Compare
Description
This PR does a few things:
Some of these commits can and probably should be squashed so that there is not a commit that would fail CI. Alternatively, we rearrange the commits so that the old workflow is removed first, and then the files are formatted, and then new workflow is added to validate.
Motivation and Context
Have been wanting to do this for a while for consistency and finally get obs-browser off of clang-format 13.0.1.
How Has This Been Tested?
Ran clang-format locally. Will see if CI passes.
Types of changes
Checklist: