Revert "Enable Qt message loop on Linux" #459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 98d94a4. Freezes with closing OAuth login window (and also while closing with browser docks) were discovered. CEF Linux build with `use_gtk=false` defined are heavily recommended.
tytan652
force-pushed
the
revert_enable_qt_loop_on_linux
branch
from
e5d1cfe
to
fc7b557
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit 98d94a4.
Freezes with closing OAuth login window (and also while closing with browser docks) were discovered.
CEF Linux build with
use_gtk=falsedefined are heavily recommended.Motivation and Context
Discovered freeze issue with closing OAuth login dialog while "investigating" What's New dialog freezes.
This PR only fixes the former, the latter might require changes on how it gets destroyed.
How Has This Been Tested?
Types of changes
Checklist: