Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand panel shutdown event listener to all platforms #463

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WizardCM
Copy link
Member

@WizardCM WizardCM commented Nov 2, 2024

Description

This expands the previously introduced shutdown loop check for browser docks to Windows and macOS.

As a reminder, this solves a potential crash on shutdown if the user has many docks or heavy docks.

As this solution has a timeout (max 1 second per dock), I am much more comfortable expanding its usage to all platforms compared to the original solution.

Motivation and Context

I have a feeling that users on other platforms have been running into this issue, but because we don't provide CEF symbols (and because it occurs on shutdown) reports have been sporadic and/or lacking the necessary detail to track it down.

How Has This Been Tested?

Close browser docks manually and on shutdown, experience no crash.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the Bug Fix Non-breaking change which fixes an issue label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant