Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps.ffmpeg: Fix MbedTLS compile error with Clang 15 #230

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

PatTheMav
Copy link
Member

Description

Fixes compilation errors of MbedTLS when compiling with Clang 15.

Motivation and Context

Clang 15 is the default compiler version on current macOS versions. The only reason this bug doesn't occur on CI is because the macOS 13 runners (and associated default Xcode version) are outdated.

How Has This Been Tested?

Tested with Clang 15 on macOS 14.2.1.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX RytoEX self-assigned this Jan 19, 2024
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine for our purposes. It does have the limitation that if there is no CMAKE_C_FLAGS set in args, it will do nothing, but we currently always set those.

Will merge when I do a cleanup pass of obs-deps.

@RytoEX RytoEX merged commit cb0e335 into obsproject:master Jan 24, 2024
21 checks passed
@PatTheMav PatTheMav deleted the mbedtls-clang-15-fix branch January 25, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants