-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #239
Update dependencies #239
Conversation
What are your thoughts on reverting https://codereview.qt-project.org/c/qt/qtbase/+/525424 for macOS (see https://bugreports.qt.io/browse/QTBUG-121351)? |
I would want a bit more context. |
In Qt 6.5, Qt added the native dialogs for QMessageBox, which made use of the native OS API's to display the message box. Imo, this looks far superior to the non-native version. In short, this patch update will make us lose native dialogs unless the commit is reverted (qt/qtbase@1b71e2d in dev or qt/qtbase@04dda6c in 6.6). |
And we have confirmed that this actually happens with Qt 6.6.2 and OBS? Do we have a simple reproducer for the QTBUG that isn't OBS itself? |
I have confirmed that this actually happens with OBS, yes. I also now reconfirmed with the artefact of this PR.
Seeing that I did not attach it to the QTBUG I don't think it exists, but it should be trivial to create one if required. It did just cross my mind that in theory, we could widget->setAttribute(Qt::WA_StyleSheet, false); on a |
I'll have to mull over which I prefer. On the QTBUG side, I find they're more apt to address bugs for which there is a trivial reproducer attached so they can quickly observe the issue. |
Revert qtbase 1b71e2d894c2be7052518cdcb96020c9950e2dc7: QMessageBox: don't use a native dialog if a style sheet is active The commit in question causes us to lose native dialogs on macOS. We can restore them by reverting the above commit. This is hopefully a temporary measure until either this is addressed in Qt itself or we get guidance on the correct way to deal with this.
Description
Update dependencies that have patch updates available. We are not updating minor/major versions at this time.
The update from libpng 1.6.40 to 1.6.42 has been left out because it would require adjustments to our patch. I would rather us spend time and effort getting that upstreamed.
Motivation and Context
Patch updates should be safe for us to adopt.
How Has This Been Tested?
I haven't tested these beyond checking that the deps build on my fork. I haven't tested building/running OBS with these yet. Testing appreciated.
Types of changes
Checklist: