deps.qt: Update Qt build options #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After checking the Qt docs, it seems that some of the options we attempted to set were being set incorrectly. https://github.com/qt/qtbase/blob/v6.6.3/cmake/configure-cmake-mapping.md
This was already disabled on Windows.
This is normally autodetected, but we can explicitly enable or disable it. To prevent unwanted surprises, it's probably safer to disable it.
PatTheMav
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Qt build options:
While vcpkg is not currently installed on the GitHub macOS runners, vcpkg is available on macOS in general, so I've disabled it in both Windows and macOS scripts in case vcpkg is ever present.
Motivation and Context
Want to have correct and consistent Qt configure options.
How Has This Been Tested?
Checked the configure results locally and on my fork's CI. I haven't done a full build with these options, but the configuration succeeded.
Types of changes
Checklist: