Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Make list widgets look consistent #11515

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cg2121
Copy link
Contributor

@cg2121 cg2121 commented Nov 13, 2024

Description

The scene and source list widget items were different heights. This sets a height in the themes instead of padding. The source tree delegate is also removed in this code.

Before:
Screenshot from 2024-11-12 19-25-09

After:
Screenshot from 2024-11-12 21-28-30

Motivation and Context

Make UI look better

How Has This Been Tested?

Looked at each list widget to make sure they looked good

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@cg2121 cg2121 added Code Cleanup Non-breaking change which makes code smaller or more readable Bug Fix Non-breaking change which fixes an issue UI/UX Anything to do with changes or additions to UI/UX elements. labels Nov 13, 2024
The scene and source list widget items were different heights. This
sets a height in the themes instead of padding. The source tree delegate
is also removed in this code.
@gxalpha
Copy link
Member

gxalpha commented Nov 13, 2024

Did you ensure that past issues with gaps between sources in that list didn’t come back? In particular, if you dragged another source into the gap, it would end up at the bottom (See also https://bugreports.qt.io/browse/QTBUG-106395).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue Code Cleanup Non-breaking change which makes code smaller or more readable UI/UX Anything to do with changes or additions to UI/UX elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants