Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix handling of Amazon IVS auto URLs when using multitrack video output #11525

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

palana
Copy link
Contributor

@palana palana commented Nov 14, 2024

Description

Allow multitrack video to work with Amazon IVS Auto (RTMPS) and Auto (RTMP) server entries selected

Motivation and Context

Amazon IVS uses two auto entries:

  • auto-rtmp for rtmp URLs
  • auto-rtmps for rtmps URLs

since channels by default only allow RTMPS, not RTMP (RTMP is a separate toggle when creating/modifying the channel).

With multitrack video, the effective server for "auto" entries is selected by the GetClientConfiguration call, where the response both RTMPS and RTMP entries generally; which of these should be used depends on whether RTMPS or RTMP is selected, hence the preference of using RTMP or RTMPS needs to be visible to the multitrack video output.

How Has This Been Tested?

Streamed up to an Amazon IVS channel with "Auto (RTMP)" and "Auto (RTMPS)" selected, and checked the log for the correct protocol

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@koolscooby
Copy link

Note: this is a bugfix for functionality introduced in #10634. Without it, if Amazon IVS and Auto (RTMPS, Recommended) or Auto (RTMP) are selected, an error dialog pops up "Invalid Path or Connection URL" and in the logs:

13:53:21.905: [rtmp stream: 'rtmp multitrack video'] Connecting to RTMP URL auto-rtmps...
13:53:21.907: RTMP URL: No :// in url!
13:53:21.907: [rtmp stream: 'rtmp multitrack video'] Connection to auto-rtmps failed: -1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants