+core-windows.v0.16.1 #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@toots the CI failed during two packages that build for me locally (and after it built I'm happy to try splitting this up if we can't figure out why its failing when done all at once |
WardBrian
force-pushed
the
core.v0.16.1
branch
from
ce85ef0
to
0355900
Compare
|
@WardBrian this kind of errors do occur. I think that I've had it myself with ffmpeg. If you can confirm that the CI tests do pass locally for you I'm good with merging. You can call like this: (optional: VERBOSE=1 SYSTEM_TYPE=<x86/x64>) ./tests/run_tests.sh |
|
Took the entire day to run but did succeed locally Output
|
|
Thank you! |
This was referenced Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with 0.15,
coreis now platform independent and thecore_kernellibrary just re-exportscorewith a deprecation warning: https://blog.janestreet.com/goodbye-Core_kernel/This PR updates the entire Jane Street ecosystem to v0.16.x at once. I can split it up if necessary, each successive commit should build on its own.
Note: The ppx libraries were mostly done by a small script I wrote and then manually checked before committing. I took the conservative approach of assuming that if a ppx depended on another ppx, it needed both the host version and the
-windowsversion - this may not be true in 100% of cases, so these packages may have a few too many dependencies individually.