Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yojson.2.2.2, yojson-five.2.2.2 #323

Merged
merged 9 commits into from
Aug 20, 2024
Merged

Conversation

WardBrian
Copy link
Contributor

Didn't have a chance to test locally so I'm hoping these pass CI

@WardBrian
Copy link
Contributor Author

Current failures look unrelated to my changes

@WardBrian WardBrian closed this Aug 16, 2024
@WardBrian WardBrian reopened this Aug 16, 2024
@WardBrian
Copy link
Contributor Author

@toots this is failing with

#=== ERROR while compiling conf-gcc-windows64.1 ===============================#
# context              2.1.5 | linux/x86_64 | ocaml-base-compiler.4.14.1 | file:///home/opam/opam-cross-windows
# path                 ~/.opam/4.14.1/.opam-switch/build/conf-gcc-windows64.1
# command              /usr/bin/sh -exc ${TOOLPREF64-x86_64-w64-mingw32-}gcc --version
# exit-code            127
# env-file             ~/.opam/log/conf-gcc-windows64-234-9489c4.env
# output-file          ~/.opam/log/conf-gcc-windows64-234-9489c4.out
### output ###
# + x86_64-w64-mingw32-gcc --version
# /usr/bin/sh: 1: x86_64-w64-mingw32-gcc: not found

Any ideas?

@toots
Copy link
Member

toots commented Aug 16, 2024

Yes, the image is rebuilding the base compiler and some of the expected env variables to be able to locate the cross-compiler are not set.

I'll look at it as soon as time allows. Meanwhile I'm happy to give you more access if you want to have a look too. Basically, one of two things need to happen (both would be even better)

  • The base image for the tests needs to be rebuilt and pushed to docker
  • The test script needs to be updated to include the proper env variable in case it needs to rebuild during the test in the future.

@WardBrian WardBrian closed this Aug 20, 2024
@WardBrian WardBrian reopened this Aug 20, 2024
@WardBrian
Copy link
Contributor Author

@toots looks like I unblocked CI

I think rebuilding the docker image would still be worthwhile from a speed perspective

@toots toots enabled auto-merge August 20, 2024 16:22
@toots toots disabled auto-merge August 20, 2024 16:38
@toots toots merged commit 6ffb6b7 into ocaml-cross:main Aug 20, 2024
8 of 9 checks passed
@toots
Copy link
Member

toots commented Aug 20, 2024

Thanks!

@WardBrian WardBrian deleted the yojson-update branch August 20, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants