Add a quiet flag #179
Merged
Add a quiet flag #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is general enough that different plugins would want to use it.
shym
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to add a quiet flag to ortac. The flag is exposed as part of
Ortac_core.Registrationso it can be used by different plugins. Then the flag is used byortac-qcheck-stm.Using a flag implies that there are only too level of verbosity for warnings (errors are always displayed when they occur). We may to add more control over the verbosity in the future, but I think we should wait for more stability in the warning system. Still, I believe the user can benefit from a quiet mode, especially when generating tests with dune.
Related to #151