Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dune subst silently ignores %%ID%% string when outside a git-controlled directory #10927

Closed
btjorge opened this issue Sep 16, 2024 · 0 comments · Fixed by #11028
Closed

dune subst silently ignores %%ID%% string when outside a git-controlled directory #10927

btjorge opened this issue Sep 16, 2024 · 0 comments · Fixed by #11028
Labels

Comments

@btjorge
Copy link

btjorge commented Sep 16, 2024

Note this impact file-pinned opam packages in particular

Reproduction

$ mkdir test

$ cat > dune-project << EOF
(lang dune 3.16)
(name test)
EOF

$ echo "%%NAME%%" > README.md

Expected Behavior

$ dune subst
$ cat README.md
test

Actual Behavior

$ dune subst
$ cat README.md
%%NAME%%

Specifications

  • dune 3.16.0
  • ocaml 5.2
  • debian 12
@rgrinberg rgrinberg added the bug label Oct 19, 2024
rgrinberg added a commit that referenced this issue Oct 19, 2024
Demonstrate that $ dune subst doesn't work without a VCS repo

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

<!-- ps-id: b4224db3-b2ee-4167-b03f-fd0e63148781 -->
rgrinberg added a commit that referenced this issue Oct 19, 2024
Demonstrate that $ dune subst doesn't work without a VCS repo

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
@rgrinberg rgrinberg linked a pull request Oct 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants