fix: allow [$ dune subst] to work without a repo #11028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
ps/rr/fix__allow____dune_subst__to_work_without_a_repo
branch
2 times, most recently
from
d3a62bc
to
6a1bd89
Compare
|
@anmonteiro do you want to review this one? |
rgrinberg
force-pushed
the
ps/rr/fix__allow____dune_subst__to_work_without_a_repo
branch
4 times, most recently
from
0110d5c
to
0345e43
Compare
anmonteiro
approved these changes
Oct 23, 2024
Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: f64f12f2-a4d9-4de3-a800-a61cc9af0e4f -->
rgrinberg
force-pushed
the
ps/rr/fix__allow____dune_subst__to_work_without_a_repo
branch
from
0345e43
to
2dbec42
Compare
rgrinberg
deleted the
ps/rr/fix__allow____dune_subst__to_work_without_a_repo
branch
|
The fix introduce a regression when an opam file is present, I just opened #11045 reporting that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rudi Grinberg me@rgrinberg.com