fix(pkg): print depexts message when a program is not found #11005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gridbugs
reviewed
Oct 9, 2024
src/dune_rules/pkg_rules.ml
Outdated
| let _, loc = pkg in | ||
| let depexts_msg = if List.is_empty depexts then [] else Depexts.message depexts in | ||
| let error_msg = (Action.Prog.Not_found.message e).paragraphs in | ||
| raise (User_error.E (error_msg @ depexts_msg |> User_message.make ~loc)) |
There was a problem hiding this comment.
It might be simpler to set the hint field of e. The benefit is that it would let us avoid adding new code to the engine.
There was a problem hiding this comment.
Is there a particular reason to not use User_error.raise? I feel it makes the code easier to mentally parse.
There was a problem hiding this comment.
The suggestion of @gridbugs was good one that simplifies the code.
moyodiallo
force-pushed
the
fix-for-depexts-bug
branch
from
b5dc57f
to
869c47b
Compare
Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
moyodiallo
force-pushed
the
fix-for-depexts-bug
branch
from
869c47b
to
1702a2a
Compare
rgrinberg
force-pushed
the
fix-for-depexts-bug
branch
from
1611e82
to
74f7344
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10988.