fix(pkg): add location hash mismatch error #11007
Conversation
| @@ -41,6 +41,7 @@ We add the bar dependency to the test package | |||
|
|
|||
| It fails as we have not regenerated the lock: | |||
| $ dune build | |||
| File "dune.lock", line 1, characters 0-0: | |||
There was a problem hiding this comment.
Isn't it more confusing to have a pointer to the file with specific line and characters instead of just the instruction to run dune pkg lock? I would understand with just the filename (as a dir) but here, it might create the inverted effect and push the user to have a look at the directory. Wouldn't it be possible to have Directory "dune.lock" instead of File "dune.lock", line 1, characters 0-0?
There was a problem hiding this comment.
Without the location, how does the user know which lock directory is out of date? Also, to display the error in the editor, some sort of location must be attached according to LSP.
There was a problem hiding this comment.
I agree with all of this. The part I find to be confusing is the mix of File and line whereas we are talking about a directory.
There was a problem hiding this comment.
I could pick the lock.dune file inside dune.lock.
There was a problem hiding this comment.
You are right. It might be more understandable from a user perspective.
We use the lcok directory as the location rather than pointing at the hash, as the user shouldn't really touch the hash. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: eee60b87-135e-4aa0-b63e-812c26bb44a2 -->
rgrinberg
force-pushed
the
ps/rr/fix_pkg___add_location_hash_mismatch_error
branch
from
fddcaf7
to
6c3f488
Compare
rgrinberg
deleted the
ps/rr/fix_pkg___add_location_hash_mismatch_error
branch
We use the lock directory as the location rather than pointing at the hash, as the user shouldn't really touch the hash.
Signed-off-by: Rudi Grinberg me@rgrinberg.com