Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] clean up 0install codebase further #11121

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[refactor] clean up 0install codebase further #11121

wants to merge 2 commits into from

Conversation

ElectreAAS
Copy link
Collaborator

This PR is a follow-up to #11015, in that it cleans up the now un-vendored opam-0install/0install directories.
The two commits are independent and can be reviewed separately.

@ElectreAAS
replace threaded monad by its explicit call to fiber in 0install
4b5b268 
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
@ElectreAAS
Replace local stdlib redefinition by stdune's definitions
fb3e1a7 
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
@rgrinberg
Copy link
Member

Ci doesn't seem happy on 4.14:

cd _boot && /home/runner/work/dune/dune/_opam/bin/ocamlopt.opt -c -g -no-alias-deps -w -49-6 -alert -unstable -I +threads zeroinstall_solver__Diagnostics.ml
File "src/0install-solver/diagnostics.ml", line 416, characters 22-37:
Error: Unbound value RoleMap.of_list
make: *** [Makefile:32: _boot/dune.exe] Error 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElectreAAS @rgrinberg