Allow esy as merlin-command to call merlin via esy exec-command
#996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't use emacs so don't really know if this is the correct way to implement this but the idea is sound — I used the same in vim before I switched to merlin-lsp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same idea as the
'opammerlin command, howeveresy exec-commandis a lot quicker so we can call it directly rather than grabbing it's config and setting the PATH.This means we have to allow
merlin-commandto return more than just the binary name as we need the additional base args - hopefully I've updated all the call sites that depend on that but would appreciate a second pair of eyes!