Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new option to mute the hover response. #1416

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Conversation

voodoos
Copy link
Collaborator

@voodoos voodoos commented Dec 6, 2024

As far as I know it is not possible to disable the default hover provider on the client side in vscode due to how the official LSP client implementation manage it.

However it is sometimes necessary to disable that hover provider to provide alternative information in the hover tooltips without additional clutter.

This PR introduces an option that allows the client to ask the server to not return anything when hover requests are made.

The diff is a bit larger than necessary because dune build @lint had not been run when options when last updated so the inlining has changed a bit.

The first use case for this option is described in this vscode-ocaml-platform PR: ocamllabs/vscode-ocaml-platform#1675

@coveralls
Copy link

coveralls commented Dec 10, 2024

Pull Request Test Coverage Report for Build 4650

Details

  • 6 of 40 (15.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 22.175%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ocaml-lsp-server/src/ocaml_lsp_server.ml 4 5 80.0%
ocaml-lsp-server/src/config_data.ml 2 35 5.71%
Totals Coverage Status
Change from base Build 4649: 0.04%
Covered Lines: 5651
Relevant Lines: 25484

💛 - Coveralls

Copy link
Collaborator

@xvw xvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow configuration capabilities are hard!

ocaml-lsp-server/src/config_data.ml Show resolved Hide resolved
ocaml-lsp-server/src/config_data.ml Show resolved Hide resolved
@voodoos voodoos merged commit 8d0c35c into ocaml:master Dec 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants