Use DocumentUri converter directly in Merlin Call Compatible params#1429
Open
voodoos wants to merge 1 commit intoocaml:masterfrom
Open
Use DocumentUri converter directly in Merlin Call Compatible params#1429voodoos wants to merge 1 commit intoocaml:masterfrom
voodoos wants to merge 1 commit intoocaml:masterfrom
Conversation
Pull Request Test Coverage Report for Build 4671Details
💛 - Coveralls |
This makes the intent clearer.
6f31e28 to
beaf5de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It makes the intent clearer than relying on "unwrapping" a
TextDocumentIdentifier.t(which is an object with a uniqueuri : DocumentUri.tfield).Ideally, we could change the spec of the request to better fit into the protocol to have a
textDocument : TextDocumentIdentifier.tinstead of auri : DocumentUri.t. The same information is conveyed, but the former version is the one used across the protocol and most other custom queries.We could transition by recognizing both fields until the clients are all updated ?
This is a follow-up to #1428.
cc @awilliambauer