Revert "Improving the readability of signature_help for long signatur…#1598
Merged
voodoos merged 1 commit intoocaml:masterfrom Mar 31, 2026
Merged
Revert "Improving the readability of signature_help for long signatur…#1598voodoos merged 1 commit intoocaml:masterfrom
voodoos merged 1 commit intoocaml:masterfrom
Conversation
…es (ocaml#1580)" This reverts commit f3814f6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The readability improvements to
signature-helpintroduced in #1580 are not usable, as the editors do not render the newly introduced line breaks. The UI forsignature-helpexpects the signature in a label field, and the editors render the label field contents as one-liners, ignoring line breaks.So, we have decided to revert the changes and postpone the work to find an LSP-friendly solution.
This reverts commit f3814f6.