Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] js_of_ocaml, js_of_ocaml-tyxml, js_of_ocaml-toplevel, js_of_ocaml-ppx_deriving_json, js_of_ocaml-ppx, js_of_ocaml-lwt and js_of_ocaml-compiler (5.4.0) #24069

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

hhugo
Copy link
Contributor

@hhugo hhugo commented Jul 6, 2023

Compiler from OCaml bytecode to JavaScript

CHANGES:

Bug fixes

…s_of_ocaml-ppx_deriving_json, js_of_ocaml-ppx, js_of_ocaml-lwt and js_of_ocaml-compiler (5.4.0)

CHANGES:

## Bug fixes
* Runtime: Fix recursive modules on ocaml < 4.13 (ocsigen/js_of_ocaml#1485)
* Runtime: fix hashing of NaN (ocsigen/js_of_ocaml#1475)
* Runtime: float rounding should resolve tie away from zero (ocsigen/js_of_ocaml#1475)
* Runtime: fix Gc.stat, Gc.quick_stat, Gc.get (ocsigen/js_of_ocaml#1475)
* Compiler: fix some miscompilation, probably introduced in jsoo 5.0.0,
  revealed by OCaml 5.0
@hhugo
Copy link
Contributor Author

hhugo commented Jul 7, 2023

It seems that the CI is not behaving correctly, I don't expect the following errors to happen.

  • ez_api.2.0.0 (failed: Package js_of_ocaml-lwt has no known version 5.4.0 in the repositories)
  • opam-publish.2.0.3 (failed: Package js_of_ocaml-ppx has no known version 5.4.0 in the repositories)
  • rpclib-js.6.1.0 (failed: Package js_of_ocaml-ppx has no known version 5.4.0 in the repositories)
  • rpclib-js.7.0.0 (failed: Package js_of_ocaml-ppx has no known version 5.4.0 in the repositories)
  • js_of_ocaml-tyxml.5.4.0 (failed: Package js_of_ocaml-tyxml has no known version 5.4.0 in the repositories)

Also, I've seen a bunch of no space left on disk and signal Abrt

 # (cd _build/.sandbox/f8dfd0b10f3ca18c8b3e188354b596c9/default && .ppx/0224ad3443a846e54f1637fccb074e7d/ppx.exe --cookie 'library-name="ppx_js"' -o ppx/ppx_js/as-lib/ppx_js.pp.mli --intf ppx/ppx_js/as-lib/ppx_js.mli -corrected-suffix .ppx-corrected -diff-cmd - -dump-ast)
# Command got signal ABRT.

@hhugo
Copy link
Contributor Author

hhugo commented Jul 7, 2023

I didn't see any error related to jsoo itself

@raphael-proust
Copy link
Collaborator

I can't see anything related to jsoo either. I haven't looked at the detailed reports, just the summary, so I could have missed something. Still I'm pretty sure this is ok.

@mseri mseri merged commit 4df8fe6 into ocaml:master Jul 11, 2023
@mseri
Copy link
Member

mseri commented Jul 11, 2023

Thanks!

@hhugo hhugo deleted the release-js_of_ocaml-5.4.0 branch November 28, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants